Memory-usage reduction for non-multires sculpt smoothing

Earlier tonight I committed a memory-usage reduction for the function used to generate adjacency for the smooth brush in sculpt mode:

r44933 – Reduce poly map memory usage (used by sculpt smooth brush.)

The poly map tells you which polygons use each vertex, information that is not normally available outside of edit mode.

It’s a relatively small amount of memory compared to some of the bigger mesh element/VBO allocations, but for a mesh of 1.5 million quads (non-multires) it reduces the size of the adjacency allocation from 168MB to 48MB (for 64-bit builds.)

Partial visibility in trunk

I’ve just finished committing partial visibility for sculpt mode:

  • r44864 – Don’t wait for sculpt stroke to create PBVH.
  • r44865 – Add BKE mesh function to update edge/poly hidden flags from verts.
  • r44866 – Add new CCG accessor functions.
  • r44867 – Add MDisps.hidden bitmap.
  • r44868 – Add DerivedMesh.gridHidden and CCGDM implementation.
  • r44869 – Skip hidden elements in PBVH iterator, raycast, and drawing.
  • r44870 – Copy hidden flag to vertices when applying multires modifier.
  • r44871 – Skip hidden elements in PBVH iterator, raycast, and drawing.
  • r44872 – Add partial visibility operator including keymaps and menu items.
  • r44873 – The first, and hopefully last (ha, ha) fix-up commit.

Check the documentation on the wiki for usage info. Please report any bugs you find, either here or in the Blender bug tracker.

This feature began as an ugly hack back in 2.4x, got rewritten during GSoC, and is finally committed to trunk with support from the Blender development fund. Thanks all for your help and support; there’s more to come!

Quick masking update

Here’s an updated masking patch that should apply cleanly against current trunk: masking-03.diff

Note that in this update, material colors aren’t working correctly. I’m pondering how best to address this and other drawing problems now.

Past couple days I’ve been committing some code cleanups to the non-sculpt drawing code. It’s still a lot of code to wade through, but it’s at least a little less verbose now.

Improvements for sculpt drawing

Example of multiple materials drawing correctly in sculpt mode (click to embiggen)

Recently I’ve been committing some improvements to the sculpt PBVH drawing code. None of these changes affect the fancier drawing modes — GLSL and all that is still not accelerated by the PBVH when sculpting. However, there are still some performance and feature improvements.

The most noticeable change is pictured at right: materials and shading mode (smooth/flat faces) are now drawn correctly in sculpt mode. Previously, the material and shading mode were set once for each PBVHNode (each of which typically contains thousands of polygons.) This is still the case, but now PBVHNodes are split until all the faces they contain (whether mesh or multires faces) all share the same material and shading mode.

Another recent change involves building VBOs for multires meshes. This is done by mapping a vertex buffer as write-only and copying multires grids (containing coordinate and normal data) into the buffer. There was a small bug in this code though: when sculpting on a flat-shaded model, the normals in the buffer were updated in a way that read from the buffer before writing to it. This is an invalid operation for a write-only buffer, and while most drivers won’t crash if you do it, I found that on my particular drivers (Gallium/Radeon) it makes a huge difference in performance. (This was on the order of seconds for dense meshes.)

Finally, improvements have been made to use better normals for flat shading. The results should in general look quite close to non-sculpt normals, with the exception of non-multires with VBO.

Updated mask patch

Attached below are updated patches for sculpt masking. Thanks to everyone who has already tested and given feedback.

Updates and fixes include:

  • Fixed dot and anchored stroke methods for the mask brush
  • Fixed multires ‘apply base’ and ‘delete higher’
  • Fixed multires render level
  • Added CTRL+I as a shortcut
  • Added unhiding to menu (menu name changed to Hide/Mask)
  • Changed ‘Hide Unmasked’ to ‘Hide Masked’
  • Rebased everything to clean up the history a bit

Edit: thanks for the builds:

Sculpt Masking

The traditional demonstration on poor Suzanne.

As part of my Blender development fund work, I’m working to bring sculpt masking (a feature from the 2010 Google Summer of Code) into trunk.

Here is a patch against current trunk for testing: masking-01.diff. There’s also a tarball of the git patches if you’d prefer something more fine-grained. Note that this patch sits on top of the partial-visibility code, so you’ll find both features available after building with these patches. If you make a test build, please consider uploading it to Graphicall and post a link in the comments.

You’ll find in-progress documentation on masking in the wiki. Although these patches are not quite finished yet, they are ready for testing. I’d appreciate feedback on the masking tools. In particular, how’s the UI? And of course any notes on crashes and other bugs would be good to have as well.